Skip to content

Skip Fantom CI for platform-only pull requests - #60155

Merged
meta-codesync[bot] merged 1 commit into
react:mainfrom
rubennorte:export-D133248360
Nov 19, 2026
Merged

meta-codesync[bot] merged 1 commit into
react:mainfrom
rubennorte:export-D133248360

Conversation

@rubennorte

Copy link
Copy Markdown
Member

Summary:

Context

Fantom CI currently runs for every code change, even when a pull request only touches Android- or iOS-specific core files. Avoid building and running the host-based Fantom suite for those changes while keeping RNTester code covered.

Changes

Add a should_test_fantom path filter combining the existing Android, iOS, and documentation exclusions, except for all RNTester paths, and use it to gate build_fantom_runner. The dependent Fantom test and retry jobs consequently skip as well. Mixed Android/iOS-only changes and platform changes accompanied by documentation also skip Fantom; shared code and RNTester code changes still trigger it. The Android and iOS build filters are unchanged. Push and manual workflow runs retain their existing full coverage.

Estimated CI impact

Based on a random sample of 200 of the 2,012 PR CI runs created from October 22 through November 18, 2026 (UTC):

  • 19.3% of runs that executed Fantom tests would avoid them (29 of 150). Counting individual test executions, including retries, 18.1% would be avoided (29 of 160).
  • Estimated Fantom PR runner-cost reduction: 18.5%. At GitHub list prices, this projects to approximately $120/month or $1,400/year, with an approximate 95% sampling interval of $80–155/month.

These are sampled workload and list-price savings estimates, not verified invoice savings. Projections assume similar future PR volume and mix; discounts and credits are unknown. RNTester changes remain eligible for Fantom.

Changelog: [Internal]

Differential Revision: D133248360

Summary:
## Context
Fantom CI currently runs for every code change, even when a pull request only touches Android- or iOS-specific core files. Avoid building and running the host-based Fantom suite for those changes while keeping RNTester code covered.

## Changes
Add a `should_test_fantom` path filter combining the existing Android, iOS, and documentation exclusions, except for all RNTester paths, and use it to gate `build_fantom_runner`. The dependent Fantom test and retry jobs consequently skip as well. Mixed Android/iOS-only changes and platform changes accompanied by documentation also skip Fantom; shared code and RNTester code changes still trigger it. The Android and iOS build filters are unchanged. Push and manual workflow runs retain their existing full coverage.

## Estimated CI impact
Based on a random sample of 200 of the 2,012 PR CI runs created from October 22 through November 18, 2026 (UTC):
- 19.3% of runs that executed Fantom tests would avoid them (29 of 150). Counting individual test executions, including retries, 18.1% would be avoided (29 of 160).
- Estimated Fantom PR runner-cost reduction: 18.5%. At GitHub list prices, this projects to approximately $120/month or $1,400/year, with an approximate 95% sampling interval of $80–155/month.

These are sampled workload and list-price savings estimates, not verified invoice savings. Projections assume similar future PR volume and mix; discounts and credits are unknown. RNTester changes remain eligible for Fantom.

Changelog: [Internal]

Differential Revision: D133248360
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2026
@meta-codesync

meta-codesync Bot commented Nov 19, 2026

Copy link
Copy Markdown

@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D133248360.

@andrewdacenko andrewdacenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync
meta-codesync Bot merged commit 4634366 into react:main Nov 19, 2026
83 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @rubennorte in 4634366

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants