Repository navigation
Skip Fantom CI for platform-only pull requests - #60155
Merged
Merged
Conversation
Summary: ## Context Fantom CI currently runs for every code change, even when a pull request only touches Android- or iOS-specific core files. Avoid building and running the host-based Fantom suite for those changes while keeping RNTester code covered. ## Changes Add a `should_test_fantom` path filter combining the existing Android, iOS, and documentation exclusions, except for all RNTester paths, and use it to gate `build_fantom_runner`. The dependent Fantom test and retry jobs consequently skip as well. Mixed Android/iOS-only changes and platform changes accompanied by documentation also skip Fantom; shared code and RNTester code changes still trigger it. The Android and iOS build filters are unchanged. Push and manual workflow runs retain their existing full coverage. ## Estimated CI impact Based on a random sample of 200 of the 2,012 PR CI runs created from October 22 through November 18, 2026 (UTC): - 19.3% of runs that executed Fantom tests would avoid them (29 of 150). Counting individual test executions, including retries, 18.1% would be avoided (29 of 160). - Estimated Fantom PR runner-cost reduction: 18.5%. At GitHub list prices, this projects to approximately $120/month or $1,400/year, with an approximate 95% sampling interval of $80–155/month. These are sampled workload and list-price savings estimates, not verified invoice savings. Projections assume similar future PR volume and mix; discounts and credits are unknown. RNTester changes remain eligible for Fantom. Changelog: [Internal] Differential Revision: D133248360
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D133248360. |
andrewdacenko
approved these changes
Nov 19, 2026
andrewdacenko
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @rubennorte in 4634366 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Fantom CI currently runs for every code change, even when a pull request only touches Android- or iOS-specific core files. Avoid building and running the host-based Fantom suite for those changes while keeping RNTester code covered.
Changes
Add a
should_test_fantompath filter combining the existing Android, iOS, and documentation exclusions, except for all RNTester paths, and use it to gatebuild_fantom_runner. The dependent Fantom test and retry jobs consequently skip as well. Mixed Android/iOS-only changes and platform changes accompanied by documentation also skip Fantom; shared code and RNTester code changes still trigger it. The Android and iOS build filters are unchanged. Push and manual workflow runs retain their existing full coverage.Estimated CI impact
Based on a random sample of 200 of the 2,012 PR CI runs created from October 22 through November 18, 2026 (UTC):
These are sampled workload and list-price savings estimates, not verified invoice savings. Projections assume similar future PR volume and mix; discounts and credits are unknown. RNTester changes remain eligible for Fantom.
Changelog: [Internal]
Differential Revision: D133248360