Repository navigation
Use consistent revisions for ResizeObserver measurements - #60159
Merged
Merged
Conversation
Summary: ## Context With commit branching enabled, a React commit updates the pending React revision before it is promoted to the main shadow-tree revision. Reading the main revision directly can make `ResizeObserver` report newly mounted targets as detached with zero sizes, or report stale sizes during callback-driven updates. ## Changes - Use the existing `ShadowTreeRevisionProvider` exposed by UIManager’s consistency manager, rather than choosing the main or React revision directly. - Obtain resize-observation snapshots through the same revision-selection and caching policy used by JavaScript layout reads. - Add public-behavior tests for subscriptions from ref callbacks and layout effects, comparing delivered sizes with layout reads during the callback. - Run the existing ResizeObserver suite with commit branching both enabled and disabled, including its callback-driven resize feedback case. Changelog: [General][Fixed] - Report consistent committed sizes from `ResizeObserver` when commit branching is enabled Differential Revision: D133269095
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D133269095. |
christophpurrer
approved these changes
Nov 19, 2026
christophpurrer
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @rubennorte in 40c4620 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
With commit branching enabled, a React commit updates the pending React revision before it is promoted to the main shadow-tree revision. Reading the main revision directly can make
ResizeObserverreport newly mounted targets as detached with zero sizes, or report stale sizes during callback-driven updates.Changes
ShadowTreeRevisionProviderexposed by UIManager’s consistency manager, rather than choosing the main or React revision directly.Changelog:
[General][Fixed] - Report consistent committed sizes from
ResizeObserverwhen commit branching is enabledDifferential Revision: D133269095