Repository navigation
[Android] Skip drawing empty outset box shadows - #60164
iceberg-kitten wants to merge 1 commit into
Conversation
|
Hi @iceberg-kitten! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Warning Missing Test Plan Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
Why
A large negative spread can collapse an Android outset shadow. The inverted bounds can still reach the canvas and show up as a stray bar.
What
Skip the outset shadow when its spread leaves an empty rectangle.
Implementation
Check the computed rectangle before either drawing path. Fixes #60008.
Changelog
[ANDROID] [FIXED] - Skip outset box shadows whose spread collapses their bounds.