Skip to content

[Android] Skip drawing empty outset box shadows - #60164

Open
iceberg-kitten wants to merge 1 commit into
react:mainfrom
iceberg-kitten:fix/android-empty-outset-box-shadow
Open

iceberg-kitten wants to merge 1 commit into
react:mainfrom
iceberg-kitten:fix/android-empty-outset-box-shadow

Conversation

@iceberg-kitten

Copy link
Copy Markdown

Why

A large negative spread can collapse an Android outset shadow. The inverted bounds can still reach the canvas and show up as a stray bar.

What

Skip the outset shadow when its spread leaves an empty rectangle.

Implementation

Check the computed rectangle before either drawing path. Fixes #60008.

Changelog

[ANDROID] [FIXED] - Skip outset box shadows whose spread collapses their bounds.

@meta-cla

meta-cla Bot commented Nov 19, 2026

Copy link
Copy Markdown

Hi @iceberg-kitten!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions

Copy link
Copy Markdown

Warning

Missing Test Plan

Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: an outset boxShadow whose negative spread empties its shape paints a bar outside the view

1 participant