Repository navigation
Open
Conversation
…f production builds
javache
approved these changes
Nov 20, 2026
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D133462830. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReactDevToolsRuntimeSettingsModulebacks React DevTools "reload and profile", whose only caller,setUpReactDevTools, runs under__DEV__. Its native implementations ship in every build, so gate them onREACT_NATIVE_DEBUGGER_ENABLED_DEVONLY, which the C++ module's registration inDefaultTurboModulesalready uses.Changes
DevToolsRuntimeSettingsstore, only underREACT_NATIVE_DEBUGGER_ENABLED_DEVONLY.RCTDevToolsRuntimeSettingsClsandReactDevToolsRuntimeSettingsModuleProviderdefined, returning nil andnullptrotherwise, matchingRCTPerfMonitorCls. JS already reads the module as nullable.REACT_NATIVE_DEBUGGER_ENABLED_DEVONLYin Debug forReact-CoreModules(CocoaPods,Package.swift) and the twodevtoolsruntimesettingsCMake targets.Note
Buck targets for
React-CoreModulesanddevtoolsruntimesettingsneed the same Debug-only define, or the module is missing in internal dev builds.Changelog: [Internal]
Test Plan
React-CoreModulesbuilds from RNTester's Pods in Release and Debug. The ReleaseRCTDevToolsRuntimeSettingsModule.odefines onlyRCTDevToolsRuntimeSettingsCls; Debug defines the full class.clang++ -fsyntax-only -Wall -Wextra -Werrorwith and without the define.swift package dump-packageshows the Debug-only define onReact-CoreModules.