Repository navigation
Conversation
Visual regressionNo visual differences at ios: no capture |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With view recycling on, a recycled
Viewkeeps thenextFocusLeftof the view that used it before, so D-pad Left from the new view jumps to the old target.BaseViewManager.prepareToRecycleViewresetsnextFocusDown,nextFocusForward,nextFocusRightandnextFocusUptoView.NO_IDbut missednextFocusLeft, and a new view without the prop never sets it again. This resets it with the others.Fixes #60167
Changelog:
[ANDROID] [FIXED] - Recycled views no longer keep the
nextFocusLeftof their previous propsTest Plan:
Added
testRecycledViewDropsTheNextFocusLeftOfItsPreviousPropstoBaseViewManagerTest. It fails onmain(nextFocusLeftIdis still 10) and passes with this change../gradlew :packages:react-native:ReactAndroid:testDebugUnitTestpasses, and the Java and Kotlin format checks are clean. I didn't run the reproducer on a device.