Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, an accessible
Imagestill takes hardware-keyboard focus withfocusable={false}ortabIndex={-1}.setAccessiblesetsisFocusable, which keyboard navigation also reads, andReactImageManagerhad nofocusablesetter, so the prop did nothing.Image.android.jsalso never turnedtabIndexintofocusablethe wayViewdoes.ReactImageManagernow handlesfocusable, andReactImageViewleaves itself out ofaddFocusablesand refusesrequestFocuswhen it isfalse.isFocusablestays tied toaccessible, so TalkBack still reaches the image. A focused image stays a candidate so focus can move on from it.Image.android.jsmapstabIndextofocusablelikeView.js. This is theImageside of #59048 (View) and #59139 (Text).Fixes #60168
Changelog:
[ANDROID] [FIXED] -
focusable={false}andtabIndex={-1}take an accessibleImageout of hardware-keyboard navigationTest Plan:
Added
testFocusableFalseKeepsAccessibleImageOutOfKeyboardFocustoReactImagePropertyTest. It setsaccessibleandfocusable={false}throughupdateProperties, then checks thataddFocusablesadds nothing,requestFocusfails andisFocusablestays true, and thatfocusable={true}makes the image a candidate again. It fails onmainand passes with the change.The full ReactAndroid unit test suite passes, and
format-check-kotlin, ESLint, Prettier andflow full-checkare clean. I didn't run the reproducer on a device.