Move delayed update trigger from onPause to onDestroy#3080
Open
smz202000 wants to merge 1 commit into
Open
Conversation
Previously, delayed APK updates were triggered in onPause(), which also fires when entering PiP mode or switching activities (e.g., Manage Accounts). This caused unexpected update installations. Moved the trigger to onDestroy() so updates only install when the activity is actually being destroyed (e.g., user exits the app), avoiding the inconsistent behavior. Fixes recloudstream#1282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1282
Previously, delayed APK updates were triggered in
onPause(), which also fires when:This caused unexpected and inconsistent update installations when the user had no intention of starting an update. In the issue author's words: "if you forget about it or something and go home you inadvertently start the update which force stops the app."
Changes
onPause()in MainActivityonDestroy()in MainActivityThis ensures that delayed updates only install when the activity is actually being destroyed (e.g., when the user explicitly exits the app via back button or exit dialog), not on incidental pauses.
Testing
The change is a straightforward move of the same code block with the same behavior. The
ApkInstaller.delayedInstaller?.startInstallation()call and associated toast remain unchanged.