feat(youtube): display channel/playlist item duration, description and date#40
Open
Bnyro wants to merge 1 commit into
Open
feat(youtube): display channel/playlist item duration, description and date#40Bnyro wants to merge 1 commit into
Bnyro wants to merge 1 commit into
Conversation
Bnyro
commented
Jul 15, 2026
Comment on lines
+204
to
+205
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| date = this@toEpisode.uploadDate?.instant?.toEpochMilli() |
Author
There was a problem hiding this comment.
I don't particularly like this for 2 reasons:
toEpochMilli(and all other java.time methods) only work on Android SDK 26+, so we currently don't show the date for SDK < 26, which is ugly.- I wanted to use
addDate, but it only works with kotlinx.datetime types, not java.time types as we get from NewPipeExtractor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also does some refactoring to get rid of the duplicated
newEpisodelogic.