chore(adoption-insights): version bump to v1.51.2#3403
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
There was a problem hiding this comment.
@Eswaraiahsapram, please fix the CI so that we can get this PR in
95605f8 to
ac11717
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3403 +/- ##
=======================================
Coverage 56.59% 56.59%
=======================================
Files 2372 2372
Lines 95021 95021
Branches 26600 26603 +3
=======================================
Hits 53777 53777
Misses 40953 40953
Partials 291 291
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
bb50abf to
988ad0e
Compare
|
@Eswaraiahsapram please resolve the conflicts |
ReviewFindingsHigh
Medium
Low
Info
Previous runReviewReason: stale-head The review agent reviewed commit |
|
/fs-review |
e377c2f to
355fa45
Compare
|
🤖 Review · ❌ Terminated · Started 7:11 AM UTC · Ended 7:23 AM UTC |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| routeRef: RouteRef_2<undefined>; | ||
| }; | ||
| }>; | ||
| 'page:adoption-insights': OverridableExtensionDefinition<{ |
There was a problem hiding this comment.
[medium] scope-creep
The nav-item:adoption-insights extension definition is removed from the public API surface (report-alpha.api.md). This is a breaking change for any consumers that override or reference this extension. Bundling a breaking API surface change inside a 'chore: version bump' PR obscures it from downstream consumers who rely on API reports to track compatibility.
Suggested fix: Document this as a breaking change. If the nav-item extension removal is intentional due to the navItems API migration, it should be called out in the PR description and potentially in a changeset with a major/minor bump depending on the project's versioning policy.
|
|
||
| /** | ||
| * Shared ESLint config for frontend packages in the adoption-insights workspace. | ||
| */ |
There was a problem hiding this comment.
[low] naming-conventions
The PR changes the exported function from a named function declaration to an anonymous arrow function. The codebase is split between patterns. Consider standardizing all workspaces to one pattern.
| const nav = navItems.withComponent(item => ( | ||
| <SidebarItem icon={() => item.icon} to={item.href} text={item.title} /> | ||
| )); | ||
|
|
There was a problem hiding this comment.
[low] edge-case
The Sidebar uses nav.take() with extension IDs like 'page:search', 'page:catalog', etc. If any ID does not match the actual extension name registered by the corresponding plugin, the sidebar item will silently not render. The IDs follow standard Backstage convention and the corresponding plugins are added in App.tsx.
|
🤖 Finished Review · ✅ Success · Started 7:11 AM UTC · Completed 7:23 AM UTC |
Eswaraiahsapram
removed
workspace/ai-integrations
workspace/app-defaults
workspace/bulk-import
workspace/cost-management
workspace/extensions
workspace/global-header
workspace/homepage
workspace/konflux
workspace/lightspeed
workspace/mcp-integrations
workspace/orchestrator
workspace/quickstart
workspace/repo-tools
workspace/scorecard
labels
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
|
Closing this since the workspace got updated in #3893 to Backstage 1.52 |
4 participants
Hey, I just made a Pull Request!
Adoption Insights backstage version bump
Fix - https://redhat.atlassian.net/browse/RHIDP-13789
✔️ Checklist