fix(#3838): add pageTitleOverride to fix document-title a11y violation#3840
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3838): add pageTitleOverride to fix document-title a11y violation#3840fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add pageTitleOverride prop to all Header components in the Extensions plugin to fix the WCAG document-title accessibility violation. The Backstage Header component uses react-helmet to set the browser document title via pageTitleOverride, and without it the HTML title element remains empty, triggering an axe-core violation. Remove the skipFailures flag from the e2e accessibility test utility so violations are always enforced. The flag was a temporary measure that suppressed real WCAG violations. Now that the document-title issue is fixed, the e2e suite enforces full accessibility checks with wcag2a, wcag2aa, wcag21a, and wcag21aa tags. Closes #3838
fullsend-ai-coder
Bot
requested review from
a team,
christoph-jerolimov and
karthikjeeyar
as code owners
July 19, 2026 17:05
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3840 +/- ##
=======================================
Coverage 56.26% 56.26%
=======================================
Files 2499 2499
Lines 96058 96058
Branches 26644 26644
=======================================
Hits 54047 54047
Misses 41683 41683
Partials 328 328
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pageTitleOverride prop to all Header components in the Extensions plugin to fix the WCAG document-title accessibility violation. The Backstage Header component uses react-helmet to set the browser document title via pageTitleOverride, and without it the HTML title element remains empty, triggering an axe-core violation.
Remove the skipFailures flag from the e2e accessibility test utility so violations are always enforced. The flag was a temporary measure that suppressed real WCAG violations. Now that the document-title issue is fixed, the e2e suite enforces full accessibility checks with wcag2a, wcag2aa, wcag21a, and wcag21aa tags.
Closes #3838
Post-script verification
agent/3838-fix-extensions-a11y)8d3503a7a74718f7eea8b2568fcd31c0ef731c05..HEAD)