fix(global-header): restore keyboard navigation for menu items without links#3848
Open
its-mitesh-kumar wants to merge 1 commit into
Open
Conversation
…t links Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-1931 Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
its-mitesh-kumar
requested review from
a team,
ciiay and
divyanshiGupta
as code owners
July 19, 2026 19:31
Changed Packages
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3848 +/- ##
==========================================
- Coverage 56.26% 56.26% -0.01%
==========================================
Files 2499 2499
Lines 96058 96059 +1
Branches 26644 26647 +3
==========================================
- Hits 54047 54046 -1
- Misses 41683 41684 +1
- Partials 328 329 +1
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
Author
|
/hold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MenuSectionusedcomponent={Fragment}on MUIMenuItemwhen items had nolinkprop. React'sFragmentsilently drops all props, so MUI'srole="menuitem"andtabIndexattributes were never rendered to the DOM. This made those items invisible to MUIMenuListarrow-key traversal. The Help dropdown'sSupportButton(which manages navigation internally and has nolinkin its mount point config) was the primary victim.The fix conditionally spreads
component/toonly when a link exists, lettingMenuItemrender its default<li>with proper ARIA attributes. Non-clickable section headers now render<ListSubheader>directly instead of wrapping in a no-op<MenuItem component={Fragment}>.Fixed
Checklist
Note