orchestrator - version:bump to v1.52.0#3892
Open
lokanandaprabhu wants to merge 4 commits into
Open
Conversation
lokanandaprabhu
requested review from
a team,
christoph-jerolimov,
karthikjeeyar and
lholmquist
as code owners
July 21, 2026 10:48
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3892 +/- ##
==========================================
- Coverage 56.59% 56.59% -0.01%
==========================================
Files 2372 2372
Lines 95021 95029 +8
Branches 26591 26594 +3
==========================================
Hits 53777 53777
- Misses 39700 39708 +8
Partials 1544 1544
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
Author
Application is working fine. |
christoph-jerolimov
left a comment
christoph-jerolimov
left a comment
Member
There was a problem hiding this comment.
I didn't request a change on GH here, but maybe you can try the right @backstage/config-loader from Backstage 1.52 instead of the post-install workaround. When someone else wants merge it this way, its fine as interim solution.
Also fixes oversized CopyTextButton by replacing it with MUI IconButton, as @backstage/core-components switched to scoped CSS that can't be overridden. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The published @backstage/plugin-kubernetes-react config.d.ts has a stale import from ./src that breaks config:check. Fixed upstream in backstage/backstage#34721; this patch can be removed once the transitive dep @janus-idp/shared-react updates its version range. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the postinstall sed patch for kubernetes-react config.d.ts with a resolution pinning @backstage/config-loader to 1.10.11. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lokanandaprabhu
force-pushed
the
orchestrator/v1.52.0
branch
from
July 22, 2026 11:55
f573a2a to
f473711
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backstage release v1.52.0 has been published, this Pull Request contains the changes to upgrade orchestrator to this new release.
Please review the changelog before approving, there may be manual changes needed:
Additional fixes for Backstage 1.52.0 regressions
1.
config:checkfailure —@backstage/plugin-kubernetes-reactconfig.d.tsThe
validate configCI step fails with:Root cause:
config.d.tshas a stale, unusedimport { PodExecTerminal } from './src/...'— the./srcdirectory isn't shipped in the published package. Same class of bug as the theme plugin (#3792, #3814).Upstream fix: backstage/backstage#34721 (merged, shipped in
0.5.x). However, the transitive dependency@janus-idp/shared-reactpins^0.4.4, so our lockfile resolves to0.4.4which is still broken.Workaround: Added a
sedpatch inscripts/postinstallto strip the stale import afteryarn install. Safe to remove once@janus-idp/shared-reactupdates its range to pick up>=0.5.0.2. Oversized Run ID copy button
The copy button next to the Run ID field renders oversized after the bump.
Root cause: Backstage 1.52.0's
CopyTextButton(from@backstage/core-components) switched from a MUIIconButtontoButtonIconfrom@backstage/ui, which uses scoped CSS (width: 2rem; height: 2remviadata-sizeattributes) that cannot be overridden from consumer code. The previous CSS overrides targeting& > buttonno longer apply.Fix: Replaced
CopyTextButtonwith a MUIIconButton+ContentCopyIcon+Tooltip— the same pattern used across other workspaces (augment, boost, dcm). Addedworkflow.fields.workflowIdCopytranslation key across all 6 languages.