docs(adp): expand Excalidraw diagrams - #198
Conversation
✅ Deploy Preview for redpanda-agentic-data-plane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
malinskibeniamin
left a comment
There was a problem hiding this comment.
Automated /review: 4 finding(s).
|
Thanks @malinskibeniamin! I pushed bdfc598 to this branch with a few review fixes:
Two items from the automated review findings still need your call:
It would also be worth re-running the contrast check on the rebuilt SVGs to confirm the per-container ratios. |
|
Follow-up since my earlier comment: f5143a3 and 2d3ce5c fix text that overflowed or crowded box edges in nine diagrams, and move the note pill in mcp-gateway-connection-flow clear of the Self-managed server box. Most fixes are pure geometry (boxes widened on arrow-free edges, labels shifted). Three change wording or line breaks: "HTTPS URL as client ID" in oauth-client-onboarding-options, the re-wrapped "Acts for user at upstream system" block in remote-mcp-client-authentication, and "Gateway connection" wrapped to two lines in resource-ownership-models. Every change is in both the SVG and its I resolved the contrast and acronym threads after verifying them at head; the round-trip and published-sources threads are still open for your call. Also refreshed the PR description's commit list and re-pinned the representative diagram images to the current head. |
…e placement - Replace the ADP acronym in the resource-ownership diagram text with the spelled-out product name, in both the SVG and its Excalidraw source - Move preamble figures below the learning objectives on the CLI, coding-agents, and MCP overview pages - Move the OAuth client onboarding figure next to the intro that enumerates the three methods, and match the page's capitalization of method names in its alt text - Capitalize MCP Gateway in the architecture diagram alt text Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Widen the Selected AI Gateway box and shift its text left so the title no longer overflows the box edge, in both the SVG and its Excalidraw source. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fix text that overflowed or crowded box edges by widening boxes on arrow-free edges, shifting labels, and re-wrapping a few lines, and move the note pill in the MCP gateway flow clear of the box above it. Each change is applied to both the SVG and its Excalidraw source. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
a13f8a5 to
0820a5c
Compare
Summary
.excalidrawsource and one rendered SVGrpk ai, managed versus self-managed ownership, and OAuth client onboardingrpk ai, remote MCP authentication, and MCP tool discoveryWhy
These workflows cross authentication, gateway, protocol, runtime, and observability boundaries. Focused diagrams help users understand the paths and trust boundaries they operate without exposing internal implementation details or tying the docs to specific UI libraries.
Commits
23d6181docs(adp): add Excalidraw diagrams372d794docs(adp): expand Excalidraw diagramsbdfc598docs(adp): spell out product name in ownership diagram and tune figure placementf5143a3docs(adp): fit the gateway box title in the rpk ai workflow diagram2d3ce5cdocs(adp): keep diagram text inside its boxes across eight diagrams761e4c6docs(adp): polish Excalidraw diagramsa13f8a5docs(adp): align diagrams with product behaviorReviewer guide
modules/connect/pages/mcp-overview.adocandmodules/connect/pages/a2a-concepts.adoc.Representative diagrams
Visual review
Dogfood evidence
/tmp/visual-review-adp-diagrams-20260807.html(local evidence; representative SVGs and deploy previews are linked below)Preview pages
Test plan
git diff --check