Hide Make a contribution CTA/modal on pages from private repos - #410
Open
JakeSCahill wants to merge 2 commits into
Open
Hide Make a contribution CTA/modal on pages from private repos#410JakeSCahill wants to merge 2 commits into
JakeSCahill wants to merge 2 commits into
Conversation
DOC-2303 makes several content-source repos private (docs, cloud-docs, rp-connect-docs, adp-docs). Forking and editing on GitHub no longer works for external contributors once a repo is private, so offering that path is misleading. The inner "Edit on GitHub" link already checked page.origin.private; this applies the same check one level up, hiding the whole "Make a contribution" button and its modal, not just that one link inside it. Still-public components (docs-site, labs) are unaffected since Antora computes page.origin.private per-component automatically. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ Deploy Preview for docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📝 WalkthroughWalkthroughThe feedback footer now checks Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The linked docs-site/meta-docs/CONTRIBUTING.adoc is being removed (redpanda-data/docs-site#201) since it described a fork-and-clone workflow that no longer works once docs/cloud-docs/rp-connect-docs/ adp-docs go private. The Labs branch is unaffected — Labs stays public and keeps its own separate contribution guide. Also drops README's :url-contributing: attribute, which pointed at the same removed file and wasn't referenced anywhere else in the doc. Related: https://redpandadata.atlassian.net/browse/DOC-2303
micheleRP
approved these changes
Aug 7, 2026
micheleRP
left a comment
micheleRP
left a comment
Contributor
There was a problem hiding this comment.
LGTM — gating on page.origin.private means this is a no-op until the content repos actually flip private, so it's safe to merge ahead of Monday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to https://redpandadata.atlassian.net/browse/DOC-2303 (making
docs,cloud-docs,rp-connect-docs,adp-docsprivate).1. Hide the "Make a contribution" CTA/modal on private-origin pages
The feedback footer's "Make a contribution" button opens a modal offering "Edit on GitHub" and a link to the contribution guide — a flow that only works when the underlying repo is public. The modal already hides its own "Edit on GitHub" link via
page.origin.private(Antora's own per-page privacy flag), but the outer button + modal still rendered regardless, misleadingly inviting a contribution path that no longer works for external contributors.This applies the same
page.origin.privatecheck one level up, so the whole button and modal are hidden together on pages sourced from a private repo. Still-public components (docs-site,labs) are unaffected — nothing hardcoded to specific component names, so this holds automatically for any future component that goes private too.2. Drop the modal's now-dead generic "Contribution guide" link
For pages that stay public, the modal's second column pointed at
docs-site/meta-docs/CONTRIBUTING.adoc. That file is being removed (redpanda-data/docs-site#201) since it described a fork-and-clone workflow that no longer works once the four repos above go private. There's no public replacement destination, so the column is dropped entirely rather than repointed — it only remains for the Labs branch, which stays public with its own separate guide (/labs/contribute/). Also removes README's:url-contributing:attribute, which pointed at the same removed file and wasn't referenced anywhere else in the doc.What was checked
src/css/feedback-footer.css-.feedback-sectionusesdisplay: flex/justify-content: space-betweenwith nonth-childor fixed-count assumptions, so dropping columns doesn't break layout.contributors-modal.hbsis now redundant given the outer gate, but left in place as a harmless belt-and-suspenders check.Related PRs