test: cover list_sensors is_online_only and sensor list --online#317
Open
tomaz-lc wants to merge 1 commit into
Open
test: cover list_sensors is_online_only and sensor list --online#317tomaz-lc wants to merge 1 commit into
tomaz-lc wants to merge 1 commit into
Conversation
tomaz-lc
marked this pull request as ready for review
July 20, 2026 12:50
tomaz-lc
enabled auto-merge (squash)
July 20, 2026 12:51
The is_online_only option on Organization.list_sensors (and the --online CLI flag) had no test coverage. Add it: - Unit (SDK): is_online_only=True sends is_online_only="true" in the query; the default / explicit False omits the parameter entirely (backward compatible - the request is unchanged from before the option existed); and it composes with a selector. - Unit (CLI): `sensor list` defaults to is_online_only=False; `sensor list --online` maps to is_online_only=True. - Integration: OnlineOnly may only narrow - the online-only listing is a subset of, and no larger than, the full listing. No production code change; tests only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tomaz-lc
force-pushed
the
feat-sensor-online-only-tests
branch
from
July 20, 2026 12:58
37c8068 to
82abb20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds test coverage for the
is_online_onlyoption onOrganization.list_sensorsand thesensor list --onlineCLI flag, which shipped without tests. No production code change.Testing
is_online_only=Truesendsis_online_only="true"in the query params; the default / explicitFalseomits the parameter entirely (backward compatible - the request is unchanged from before the option existed); and it composes with aselector.sensor listdefaults tois_online_only=False;sensor list --onlinemaps tois_online_only=True.is_online_onlymay only narrow the result - the online-only listing is a subset of, and no larger than, the full listing (runs against a live org in CI).Blast radius / isolation
Related PRs
🤖 Generated with Claude Code