cloudsec(sdk): document the third finding status, "accepted"#326
Open
maximelb wants to merge 1 commit into
Open
cloudsec(sdk): document the third finding status, "accepted"#326maximelb wants to merge 1 commit into
maximelb wants to merge 1 commit into
Conversation
The findings API returns status open | resolved | accepted, not just open | resolved. `accepted` is a LIVE risk acceptance — the risk is still there and an owner signed off on carrying it — so it is deliberately not rolled into `resolved` (mitigated / false positive, where the risk is gone). The SDK docstring and the CLI --status help both enumerated only two values, which reads as "accepted findings are fixed". Also states that --expires-at / expires_at is OPTIONAL for an acceptance: omitting it accepts the risk permanently, which is a supported disposition rather than an unfinished one. Docs only; no behaviour change (status was already a passthrough filter, so `--status accepted` worked before this). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132oQ8tTsLG5qGvX1c4TiJu
lcbill
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only — companion to go-cloudsec#114 / legion_graph#97 (B3).
The findings API returns
status ∈ {open, resolved, accepted}, not justopen|resolved.acceptedis a live risk acceptance — the risk is still there and an owner signed off on carrying it — so it is deliberately not rolled intoresolved(mitigated / false positive, where the risk is gone). Two places enumerated only the old pair, which reads as "accepted findings are fixed":limacharlie/sdk/cloudsec.py:207—list_findings'status:arg (also notes the same three values are theget_finding_facetsstatusmap keys, and that a lapsed or stale-epoch acceptance readsopenagain).limacharlie/commands/cloudsec.py:859— the--statusfilter help.Also states that
--expires-at/expires_atis optional for an acceptance: omitting it accepts the risk permanently, which is a supported disposition rather than an unfinished one (set_finding_statusdocstring + both--expires-athelp strings).No behaviour change —
statuswas already a passthrough filter, so--status acceptedworked before this; it just wasn't documented.python3 -m pytest tests/unit→ 3676 passed, 6 skipped (all 6 skips pre-existing and environmental: Windows/macOS-only, orjson unavailable, twopre-existingdocstring markers).