Repository navigation
stream: wait out Connecting before watching for GOAWAY - #365
Merged
Merged
Conversation
watchGoAway drained a session as soon as the connection was not Ready. Just after the stream opens, the ClientConn can still report Connecting, so a healthy session was drained and ended at once. One-way messages that Send had accepted but gRPC had not yet written were lost. Wait for the connection to leave Connecting before treating a state change as a server GOAWAY. Closes: #364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #364.
watchGoAwaytreated any ClientConn state other thanReadyas a GOAWAY.Just after
NodeStreamreturns, the state can still beConnecting, so a healthy session was drained and ended.One-way messages that
Sendhad accepted but gRPC had not yet written were lost, which madeTestOnewayCallsflaky.The watcher now waits for
Connectingto pass first.Verified: with a
-racetest binary, four concurrent-count=1000runs ofTestOnewayCallsfailed almost every time before the change (instrumentation showedstartDraincalled in stateCONNECTING) and passed 4/4 after.No deterministic regression test: forcing the
Connectingwindow needs a hook into gRPC internals.