Repository navigation
servers: wrap bufconn fake ports within the valid range - #367
Merged
Merged
Conversation
The bufconn registry's process-wide counter never reset, so a long -count run passed port 65535 and every later test failed with an invalid address. Wrap the port; addresses only need to be distinct among the listeners alive at once. Closes: #366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366.
The bufconn address counter is process-wide and never reset, so
-count=10000ofTestOnewayCalls(13 addresses per run) overflowed the port range after about 5,500 runs.The port now wraps within 10000-65535.
Verified:
-count=10000ofTestOnewayCallspasses.