Skip to content

fix: cap editor height so long comments don't push submit button out of view [1.x] - #44

Open
lgally wants to merge 1 commit into
relaticle:1.xfrom
lgally:fix/cap-editor-height-in-slide-over
Open

lgally wants to merge 1 commit into
relaticle:1.xfrom
lgally:fix/cap-editor-height-in-slide-over

Conversation

@lgally

@lgally lgally commented Oct 21, 2026

Copy link
Copy Markdown

Problem

When a long comment is pasted into the editor (e.g. a lengthy block of text copied from another system), the rich editor grows without limit. The comment form is pinned with flex-shrink: 0, and .fi-modal-content:has(> .comments-wrap) has overflow: hidden, so the form ends up taller than the slide-over. The submit button is pushed out of view and can't be scrolled to or reached with Tab, so the comment can't be posted. The comment list above also collapses to zero height.

Fix

Cap .fi-fo-rich-editor-main inside .comments-wrap at 40vh with overflow-y: auto, so long content scrolls inside the editor and the submit button and comment list stay visible.

Testing

Rendered the Comments Livewire component in a 700px-tall slide-over and pasted several thousand characters:

  • Before: editor ~3568px tall, submit button at y≈3744 (outside the 700px window), comment list 0px.
  • After: editor 280px, submit button fully visible, comment list ~212px.

I checked this against the rendered markup with the compiled Filament theme CSS rather than with a PHP test, since it's a layout fix.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant