Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a long comment is pasted into the editor (e.g. a lengthy block of text copied from another system), the rich editor grows without limit. The comment form is pinned with
flex-shrink: 0, and.fi-modal-content:has(> .comments-wrap)hasoverflow: hidden, so the form ends up taller than the slide-over. The submit button is pushed out of view and can't be scrolled to or reached with Tab, so the comment can't be posted. The comment list above also collapses to zero height.Fix
Cap
.fi-fo-rich-editor-maininside.comments-wrapat40vhwithoverflow-y: auto, so long content scrolls inside the editor and the submit button and comment list stay visible.Testing
Rendered the
CommentsLivewire component in a 700px-tall slide-over and pasted several thousand characters:I checked this against the rendered markup with the compiled Filament theme CSS rather than with a PHP test, since it's a layout fix.