Repository navigation
fix: stop logging API tokens in toLegacyAccessKeyList - #18
Merged
Merged
Conversation
Removes a leftover debug console.log that printed the API token list response (id, description, created_at) to stdout whenever access keys were listed. Resolves CodeQL alert #2 (js/clear-text-logging). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ashirman
force-pushed
the
fix/codeql-cleartext-logging
branch
from
October 6, 2026 17:07
572be0b to
840ccdb
Compare
ashirman
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a leftover debug
console.log(apiTokens)insrc/utils/adapter/adapter.ts. It printed the raw API token list, including token values, to stdout every time access keys were listed. Fixes CodeQL alert #2 (clear-text logging of sensitive information).CodeQL alert #1 (workflow does not contain permissions) needed no change.
.github/workflows/code-push-ci.ymlhas had a top-levelpermissions: contents: readsince af0fef9 (Jul 29), which is after the alert was opened. The next CodeQL scan of master should close it.npm run buildpasses.🤖 Generated with Claude Code