Repository navigation
Conversation
luhenry
added a commit
that referenced
this pull request
Oct 13, 2026
luhenry
marked this pull request as draft
October 13, 2026 09:26
Contributor
|
The cargo registry keeps crate sources one level below registry/src (index.crates.io-<hash>/<crate>), so the -maxdepth 1 lookup found nothing and the copy failed on '/LICENSE'. The mountpoint-s3-crt-sys crate also ships no top-level LICENSE, only one per vendored CRT library, so drop that copy. mountpoint-s3-crt-sys generates its bindings with bindgen at build time, which needs libclang: install clang/clang-devel as upstream's own manylinux_2_28 before-all does.
…esis deadlines in tests The wheel built and repaired on every interpreter, but installing its own [test] extra failed: PyPI's newest Pillow (13.0.0) has no riscv64 wheel, so pip picked its sdist over the registry's 12.3.0 wheel and the build died on the missing libjpeg headers. PIP_ONLY_BINARY=pillow makes the registry wheel the only candidate. cibuildwheel's container does not inherit the runner's CI variable, so Hypothesis keeps its default 200ms per-example deadline, which the connector's unit suite already exceeds intermittently on x86_64 (test_s3_client_custom_config). CI=true selects Hypothesis' built-in ci profile, which drops the deadline and the too_slow health check.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s3torchconnectorclient1.5.0Builds the PyO3/setuptools-rust native extension wrapping AWS's Mountpoint-S3 Rust client (and its statically-linked AWS Common Runtime) that backs the
s3torchconnectorPyTorch package. Upstream publishes no riscv64 wheel.Mirrors upstream's
wheels.yml, minus its CodeBuild runner matrix and AWS-credentialed steps.Differs from upstream
license-filespoints atLICENSE.*instead of the ORT-generatedTHIRD-PARTY-LICENSES- never checked into the repoMatrix: cp312/cp313/cp314 only - s3torchconnector (its own test dependency) needs torch, which has no riscv64 wheel below cp312
Testing
CI_*-prefixed S3 integration/e2e commands - need real AWS credentials this CI has none ofLicense: Wheel statically links the AWS Common Runtime (aws-lc, s2n-tls, aws-c-common, aws-c-cal, aws-c-io, aws-c-compression, aws-c-http, aws-c-sdkutils, aws-c-auth, aws-checksums, aws-c-s3; all Apache-2.0); the build collects each one's licence text since upstream's own THIRD-PARTY-LICENSES generation step is not reproducible from a plain checkout.
Patches
0001-ship-the-licences-of-the-statically-linked-dependencies.patch- Upstream-Status: To upstream. Pointslicense-filesat the per-dependency files the build now collects; reproduces off riscv64 too.Local build skipped: this host has under 2.5 GB free, too tight to vendor the AWS-LC/s2n-tls source tree cargo needs; CI is the first real build.