Repository navigation
tcmlib: drop the 1.6.0 patches - #4142
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.6.0 carries the
-fcf-protectionx86 guard upstream, so its patch was deliberately dropped in #3735 andbuild-tcmlib.ymlonly applies a patches directory when one exists for the version.The nightly run then copied the 1.5.0 patch into
patches/tcmlib/1.6.0/again, on a stale package branch that did not yet have 1.6.0 (#4128). The patch is byte-identical to the 1.5.0 one, and the next 1.6.0 build would try to apply it to code that no longer needs it.This removes
patches/tcmlib/1.6.0/. The published 1.6.0 wheel was built without it. The cause is the same as for lancedb 0.40.0, and the--base-filechange tocheck_versions.pystops it happening again.Testing
None needed beyond the diff: it only deletes the directory the workflow checks for.