fix: pin npm to v11 as latest compatible version for our node runner#435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as rive-app/rive-nitro-react-native#340: npm v12 dropped support for the Node version pinned in
.nvmrc(v20.19.0, npm 12 requires Node >=22.22.2), so thenpm install -g npm@lateststep in the publish workflow fails withEBADENGINE. This is why the v9.8.4 publish run failed and 9.8.4 never reached npm. Pinning to npm v11 (which still has OIDC support, since 11.5.1) unblocks publishing; updating.nvmrccan be looked at separately.Note: since the v9.8.4 tag predates this fix, re-running that publish won't pick it up — the next release (9.8.5) will publish cleanly and carry the 9.8.4 changes.