Skip to content

chore(container-runner): default stop grace to 10s - #5533

Open
abcxff wants to merge 1 commit into
stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpumfrom
stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup
Open

chore(container-runner): default stop grace to 10s#5533
abcxff wants to merge 1 commit into
stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpumfrom
stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup

Conversation

@abcxff

@abcxff abcxff commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@claude

claude Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review

Small, focused change: lowers --stop-grace-secs / RIVET_STOP_GRACE_SECS default from 25 to 10 in container-runner/src/main.rs. The change itself is safe -- sleep_grace_period is derived from stop_grace dynamically (stop_grace + Duration::from_secs(10) in async_main), so nothing else hardcodes the old value in code.

Issue: stale docs reference the old default (25)

Three places still document 25 as the default and will now be wrong:

  • website/src/content/docs/deploy/container-runner.mdx:81
  • docs/docs/deploy/container-runner.mdx:81
  • container-runner/examples/unity-demo/Dockerfile:32 (comment: RIVET_STOP_GRACE_SECS ... (default 25))

Per this repo's docs-sync convention, please update these alongside the code default so they don't drift. I checked the rest of the stack (#5531 downstream, and the other container-runner PRs in this chain) and did not see a follow-up that fixes these, so they look like they would stay stale after merge.

Minor

  • No test coverage change, but this is a default_value_t tweak on a CLI arg, not really testable beyond a smoke test, so that is fine as-is.
  • A one-line PR description noting why 10s was chosen over 25s (e.g. faster shutdowns / fitting inside a platform kill window) would help future readers, especially since the Dockerfile comment references the sleep_grace_period cap logic tied to this value.

Overall: safe change, just needs the doc/comment sync.

@abcxff
abcxff force-pushed the stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpum branch from f63600c to efaf873 Compare July 31, 2026 05:27
@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch from c142ce3 to 4a79659 Compare July 31, 2026 05:27
@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch from 4a79659 to 395bd37 Compare July 31, 2026 06:03
@abcxff
abcxff force-pushed the stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpum branch from efaf873 to 11b03c3 Compare July 31, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant