Repository navigation
ci: run the live GitHub tests on every pull request and push - #73
Merged
Merged
Conversation
The live suite now also covers the default `rr get`, which must resolve to the 3.x line rather than a calendar version, and `rr versions`, which reads the releases without DLoad. Both assert what holds for any future release. GITHUB_TOKEN and DLOAD_CACHE_DIR are passed through to rr so CI can share one version registry across tests and runs. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
The live job used to run only on workflow_dispatch. It costs about 6 API requests per job, so it fits the GITHUB_TOKEN limit easily; the DLoad version registry is cached between runs to spare the release pages already seen. rr always passes `--refresh`, so each `rr get` still checks the newest page, which is what a live test should exercise. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
Live GitHubjob runs on pull requests and pushes to3.x, not only onworkflow_dispatch; it carries no matrix expression in its name anymore.DLOAD_CACHE_DIR) is kept between runs withactions/cache, keyed per OS and run with a per-OSrestore-keysfallback; the job prints theGITHUB_TOKENAPI usage before and after the tests.rr getresolves to the 3.x line rather than a calendar version, and thatrr versionsreads the real releases. Assertions hold for any future release.Why?
GITHUB_TOKEN.Review notes
rr getalways passes--refreshto DLoad, and this stays: with a warm registry a refresh costs one request (the newest page) instead of zero, and older pages still come from the cache. Without the refresh the live job would test the cache, not GitHub.rr versionsuses its own client and bypasses the registry: 2 requests per run.Checklist
RR_CLI_LIVE_TESTS=1; request count measured from DLoad's-vvvlog, cold and warm registrySummary by CodeRabbit