Skip to content

ci: run the live GitHub tests on every pull request and push - #73

Merged
roxblnfk merged 2 commits into
3.xfrom
ci/live-tests
Oct 12, 2026
Merged

roxblnfk merged 2 commits into
3.xfrom
ci/live-tests

Conversation

@roxblnfk

@roxblnfk roxblnfk commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

🔍 What was changed

  • The Live GitHub job runs on pull requests and pushes to 3.x, not only on workflow_dispatch; it carries no matrix expression in its name anymore.
  • The DLoad version registry (DLOAD_CACHE_DIR) is kept between runs with actions/cache, keyed per OS and run with a per-OS restore-keys fallback; the job prints the GITHUB_TOKEN API usage before and after the tests.
  • The live suite also checks that a plain rr get resolves to the 3.x line rather than a calendar version, and that rr versions reads the real releases. Assertions hold for any future release.

Why?

  • Live tests caught nothing while they ran only by hand. A job costs about 6 API requests (5 with a warm registry), far below the 1000 requests per hour of GITHUB_TOKEN.

Review notes

  • rr get always passes --refresh to DLoad, and this stays: with a warm registry a refresh costs one request (the newest page) instead of zero, and older pages still come from the cache. Without the refresh the live job would test the cache, not GitHub.
  • rr versions uses its own client and bypasses the registry: 2 requests per run.

Checklist

  • How was this tested:
    • Live suite run locally with RR_CLI_LIVE_TESTS=1; request count measured from DLoad's -vvv log, cold and warm registry
    • Unit, Acceptance, Psalm and php-cs-fixer pass locally

Summary by CodeRabbit

  • Tests
    • Expanded live GitHub checks to verify the default Linux download reports a valid release version and that release compatibility information is reported correctly.
    • Live acceptance checks now run for all workflow-triggering events, and API usage is reported before and after testing.

The live suite now also covers the default `rr get`, which must resolve to the 3.x line rather than a calendar version, and `rr versions`, which reads the releases without DLoad. Both assert what holds for any future release. GITHUB_TOKEN and DLOAD_CACHE_DIR are passed through to rr so CI can share one version registry across tests and runs.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
The live job used to run only on workflow_dispatch. It costs about 6 API requests per job, so it fits the GITHUB_TOKEN limit easily; the DLoad version registry is cached between runs to spare the release pages already seen. rr always passes `--refresh`, so each `rr get` still checks the newest page, which is what a live test should exercise.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
@roxblnfk
roxblnfk requested a review from a team October 12, 2026 10:49
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1ece486c-677f-446a-8ea2-c8e54e37ba5b

📥 Commits

Reviewing files that changed from the base of the PR and between d38492e and 37a5c15.


📒 Files selected for processing (2)
  • .github/workflows/acceptance.yml
  • tests/Live/GitHubTest.php

 __________________________________________________________________________________________
< Recursion is the root of computation since it trades description for time. - Alan Perlis >
 ------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@roxblnfk
roxblnfk merged commit 27a2416 into 3.x Oct 12, 2026
15 of 16 checks passed
@roxblnfk
roxblnfk deleted the ci/live-tests branch October 12, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant