chore(tests): drive RPC over goridge net/rpc again#226
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
Pull request overview
Reverts the test harness from Connect-RPC back to RoadRunner’s goridge net/rpc transport for exercising the Jobs/KV plugin RPC surfaces, aligning tests with the org-wide Connect-RPC revert while keeping the current api-go message set.
Changes:
- Removed native Connect-RPC smoke tests for KV and Jobs.
- Updated KV/Jobs integration tests to invoke RPC methods via goridge
net/rpc(client.Call) instead ofconnectrpc.com/connect. - Updated
testsmodule dependencies to point at revert-branch pseudo-versions and removed Connect-RPC-related deps.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/kv_native_test.go | Removes KV Connect-RPC smoke test. |
| tests/kv_memory_test.go | Switches KV calls from Connect-RPC client methods to goridge net/rpc calls. |
| tests/jobs_native_test.go | Removes Jobs Connect-RPC smoke test. |
| tests/jobs_memory_test.go | Switches Jobs calls from Connect-RPC client methods to goridge net/rpc calls. |
| tests/helpers/helpers.go | Replaces Connect-RPC clients with goridge net/rpc dialing and helper calls. |
| tests/go.mod | Drops Connect-RPC deps; adds/pins goridge and revert-branch pseudo-versions for plugin deps. |
| tests/go.sum | Removes Connect-RPC-related sums; updates sums for pinned pseudo-versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The reply value st is allocated locally as &jobsProto.Stats{} and net/rpc
decodes into it without reassigning, so require.NotNil(t, st) is always
true. The following require.NotEmpty(t, st.GetStats()) is the meaningful
check.
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Part of the org-wide Connect-RPC revert: test helpers drive the RPC surface over goridge net/rpc again, keeping the current api-go message set. Plugin deps in tests/go.mod are pinned to the revert branches (pseudo-versions to be replaced by tags). No changes outside tests/.