Skip to content

Refresh date when day changes while page is not visible #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rob93c merged 2 commits into from
Aug 8, 2026
Merged

Refresh date when day changes while page is not visible #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b94d524
Add logic to determine if the day changed while the page was opened a…
rob93c Aug 8, 2026
41a1570
Trigger refresh only when the last known today is stale
rob93c Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions src/components/DailyQuestion.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
<script setup lang="ts">
import { computed, inject, ref, watch } from 'vue';
import { computed, inject, ref, watch, onMounted, onBeforeUnmount } from 'vue';
import { useI18n } from 'vue-i18n';
import { DateTime } from 'luxon';

const theme = inject('theme');
const { t, d, locale } = useI18n();

const today = DateTime.now().startOf('day');
const getToday = () => DateTime.now().startOf('day');

const getIntro = (dateTime: DateTime) => {
const today = getToday();
if (dateTime > today) {
return t('futureQuestion', { date: d(dateTime.toJSDate(), 'long') });
} else if (dateTime < today) {
Expand All @@ -18,31 +19,30 @@ const getIntro = (dateTime: DateTime) => {
}
};

let intro = ref(getIntro(today));
let intro = ref(getIntro(getToday()));

const loadQuestion = (dateTime: DateTime) => {
intro.value = getIntro(dateTime);

return t(`questions.${dateTime.month}.${dateTime.day}`);
};

let dailyQuestion = ref(loadQuestion(today));
let customDate = ref<string>(today.toFormat('yyyy-MM-dd'));
let selectedDate = ref<DateTime>(today);
let dailyQuestion = ref(loadQuestion(getToday()));
let customDate = ref<string>(getToday().toFormat('yyyy-MM-dd'));
let selectedDate = ref<DateTime>(getToday());
const previousDay = computed(() => selectedDate.value.minus({ days: 1 }));
const nextDay = computed(() => selectedDate.value.plus({ days: 1 }));

const handleChange = () => {
selectedDate.value = DateTime.fromISO(customDate.value).startOf('day');
dailyQuestion.value = loadQuestion(selectedDate.value);
totalDays.value = getDaysInYear(selectedDate.value)
totalDays.value = getDaysInYear(selectedDate.value);
};

const getDaysInYear = (dateTime: DateTime) => {
return dateTime.isInLeapYear ? 366 : 365;
};

let totalDays = ref(getDaysInYear(today));
let totalDays = ref(getDaysInYear(getToday()));

const refreshContent = (dateTime: DateTime) => {
dailyQuestion.value = loadQuestion(dateTime);
Expand All @@ -54,6 +54,28 @@ const refreshContent = (dateTime: DateTime) => {
watch(locale, () => {
dailyQuestion.value = loadQuestion(selectedDate.value);
});

let lastKnownToday = ref(getToday());

const onVisible = () => {
const today = getToday();

if (!lastKnownToday.value.equals(today)) {
if (document.visibilityState === 'visible' && selectedDate.value.equals(lastKnownToday.value)) {
refreshContent(today);
}

lastKnownToday.value = today;
}
};
Comment thread
coderabbitai[bot] marked this conversation as resolved.

onMounted(() => {
document.addEventListener('visibilitychange', onVisible);
});

onBeforeUnmount(() => {
document.removeEventListener('visibilitychange', onVisible);
});
</script>

<template>
Expand All @@ -79,7 +101,7 @@ watch(locale, () => {
@click="refreshContent(previousDay)"><
</button>
<button :class="['btn', theme]" type="button"
@click="refreshContent(today)">{{ $t('today') }}
@click="refreshContent(getToday())">{{ $t('today') }}
</button>
<button :class="['btn', theme]" type="button"
:aria-label="$t('nextDay')"
Expand Down