Avoid recursive SQLite row decoder check hang - #498
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid Roc issue roc-lang/roc#11621 in the SQLite row decoder. The recursive local function combined
?propagation with inferred result types, which makes the September 23 compiler spin duringroc checkeven for a hello-world app importing this platform.Use explicit result matches in the recursive row collector. Use the same form in the two unannotated query wrappers, where the compiler otherwise reports error-row type mismatches after the hang is removed. The success and error paths are unchanged.
Validation
With Roc nightly-2026-09-23-c7852fd and a local platform reference:
roc check examples/hello-world-local.roc --no-cacheexceeded a 20-second timeout.roc check --no-cachein about 0.1 seconds.roc test --no-cache(213 tests).roc fmt --check platform/Sqlite.rocpasses.The local-reference files were temporary copies and are not included in this PR. CI remains pinned to the September 22 compiler; this PR does not publish a basic-cli release or change downstream release URLs.