Repository navigation
chore(deps): update @rocicorp/zero to 1.10.0 - #25
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
0 open findings
What changed in this PR
Updates @rocicorp/zero to stable 1.10.0 and regenerates schema metadata.
Changes:
- Updates dependency and lockfile entries.
- Adds generated
.unique()declarations forOrgandTreeNode.
| File | Description |
|---|---|
pnpm-lock.yaml |
Locks stable Zero 1.10.0. |
package.json |
Updates the Zero devDependency. |
integration/generated/zero/schema.ts |
Adds generated unique-key metadata. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Verify Signed Commit Authors fails because Generated by Claude Code |
The checked-in output predates the unique-key generation from #23. `pnpm test` regenerates it with the `.unique()` calls for Org and TreeNode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@rocicorp/zerodevDependency to the stable1.10.0instead of1.10.0-canary.17. Only the Zero entries change inpnpm-lock.yaml.integration/generated/zero/schema.ts. The checked-in copy predates the unique-key generation from feat: support Zero 1.10 unique keys #23, sopnpm testrewrote it with.unique()calls forOrgandTreeNode. Unmodifiedmainproduces the same diff.Why
#23 merged while the devDependency still pointed at a canary. The published 0.3.0 isn't affected: the build treats
@rocicorp/zeroas external and the package only declares a>=1.10.0peer dependency.Testing
check-types,lint,check-format,buildandtest(272 tests, no type errors) pass locally with pnpm 11.1.3.🤖 Generated with Claude Code
https://claude.ai/code/session_01RRckJnCeGsYg9nCJSxBgTJ
Generated by Claude Code