Repository navigation
docs: correct copy-pasted comments in client managers - #1294
Merged
Merged
Conversation
Signed-off-by: kleonyuan <kleonyuan@outlook.com>
0xfornax
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two doc comments are left over from the function above them and describe
the wrong thing.
shared/services/ec-manager.go:445—ExecutionClientManager.ChainIDwasdocumented as "BlockNumber returns the most recent block number", a
verbatim copy of the comment on
BlockNumberat line 352. It now reads"ChainID returns the chain ID of the execution client".
shared/services/bc-manager.go:159—BeaconClientManager.GetEth2DepositContractwas documented as "Get the Beacon configuration", a verbatim copy of the
comment on
GetEth2Configat line 148. It now reads "Get the eth2 depositcontract info", matching the wording already used by the same method in
shared/services/beacon/client/std-http-client.go:170.