Skip to content

Gloas builder params - #1296

Open
0xfornax wants to merge 10 commits into
masterfrom
gloas-builder-params
Open

0xfornax wants to merge 10 commits into
masterfrom
gloas-builder-params

Conversation

@0xfornax

Copy link
Copy Markdown
Member

Add shared ePBS builder settings (minimum bid, max execution payment, and operator list) under a new TUI ePBS page, and migrate existing local MEV-Boost / Commit-Boost relay selections into them.

Start scripts are adjusted to use the Gloas params. Waiting on sigp/lighthouse#10374 so Lighthouse would have similar CLI options.

@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service/config 0.00% (ø)
github.com/rocket-pool/smartnode/shared/services/config 7.34% (-0.09%) 👎
github.com/rocket-pool/smartnode/shared/services/config/migration 2.85% (+0.45%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-builder.go 0.00% (ø) 695 (+695) 0 695 (+695)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-commit-boost.go 0.00% (ø) 2795 0 2795
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-epbs.go 0.00% (ø) 1150 (+1150) 0 1150 (+1150)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-home.go 0.00% (ø) 3710 (-109) 0 3710 (-109)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-mev-boost.go 0.00% (ø) 2909 0 2909
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/standard-layout.go 0.00% (ø) 4795 0 4795
github.com/rocket-pool/smartnode/shared/services/config/epbs-config.go 4.49% (+4.49%) 1939 (+1939) 87 (+87) 1852 (+1852) 👍
github.com/rocket-pool/smartnode/shared/services/config/migration/migration-manager.go 7.83% (+0.45%) 2070 (+146) 162 (+20) 1908 (+126) 👍
github.com/rocket-pool/smartnode/shared/services/config/migration/v1245-manager.go 4.38% (+4.38%) 981 (+981) 43 (+43) 938 (+938) 👍
github.com/rocket-pool/smartnode/shared/services/config/rocket-pool-config.go 4.16% (+0.02%) 25418 (+234) 1057 (+14) 24361 (+220) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant