Repository navigation
bin/lib.sh: honor COMPOSE_FILE in start_app and start_app_service - #17
Merged
Merged
Conversation
Both ran `docker compose -f <app>/docker-compose.yml`, and an explicit -f makes Compose ignore COMPOSE_FILE from the app's .env. Since #15 moved the GPU reservation for ollama and vllm into docker-compose.nvidia.yml, the install scripts started them on the CPU; NFS and macvlan overrides were already being dropped the same way. Run from the app directory without -f, as start_experiment already does. The project name is unchanged (it was already the app directory name). Also move the start_app_service comment back above start_app_service. Reported by Cursor Bugbot on #15. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue Cursor Bugbot reported on #15 after it merged ("Install path drops GPU overrides").
start_appandstart_app_servicerandocker compose -f <app>/docker-compose.yml. An explicit-fmakes Compose ignoreCOMPOSE_FILEfrom the app's.env. Since #15 moved the NVIDIA GPU reservation for ollama and vllm intodocker-compose.nvidia.yml,install-ai-satellite.shandinstall-chaos.shwould start ollama on the CPU even when.envselects the NVIDIA override. NFS (docker-compose.nfs.yml) and macvlan (docker-compose.macvlan.yml) overrides were already being dropped the same way.Both functions now
cdinto the app directory and rundocker composewithout-f, matchingstart_experiment. The Compose project name stays the same (the app directory name), so already-running stacks are still recognised.Also moves the
start_app_servicecomment, which had drifted abovestart_experiment.Testing
bash -n bin/lib.shapps/ollama/.envselectingdocker-compose.nvidia.yml: the old-fform resolves 0 NVIDIA reservations, the new form resolves 1. The project name isollamain both cases.🤖 Generated with Claude Code
Note
Medium Risk
Changes how all installer-driven Docker starts resolve compose files; wrong cwd/env could affect GPU, NFS, or network overrides, but it fixes dropped overrides from the old
-fbehavior.Overview
start_appandstart_app_servicenow rundocker composefrom each app’s directory without-f docker-compose.yml, so Compose picks upCOMPOSE_FILEfrom the app’s.env(NVIDIA, NFS, macvlan, and similar overrides). Previously the hard-coded-fpath ignored those settings—e.g. ollama/vllm could start without GPU reservations after overrides moved into separate compose files.Behavior matches
start_experiment: same project naming from the app dir, so “already running” checks should still work. Thestart_app_servicedoc comment is moved back above that function (it had sat abovestart_experiment).Reviewed by Cursor Bugbot for commit 6dc366c. Bugbot is set up for automated code reviews on this repo. Configure here.