[cmake] modernize and simplify RConfigure, RVersion and RConfig generation - #23291
Draft
ferdymercury wants to merge 5 commits into
Draft
ferdymercury wants to merge 5 commits into
ferdymercury wants to merge 5 commits into
Conversation
inbuilt configure file and mention also current cplusplus not just ROOT in error message
via header guards
ferdymercury
changed the title
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 9f57ee8. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
from copilot sister PR pcanal Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
guitargeek
pushed a commit
that referenced
this pull request
Sep 19, 2026
The generated compiledata.h header is only meant to be used internally by ROOT to set up ACLiC, but it was missing header guards and could be included by user code without any warning. - Add header guards to the header generated by cmake/unix/compiledata.sh. - Emit a #warning when the header is included from outside ROOT internals, i.e. unless ROOT_compiledata_cxx, G__DICTIONARY or __ACLIC__ is defined. The warning says the header will be renamed in ROOT 6.44 and points users to gSystem instead. - Define ROOT_compiledata_cxx in the four internal users (TSystem, TCling, TFile, TApplicationServer) to silence the warning there. - Add a note to the v6.42 release notes. The header is kept for now because it is useful for debugging user installations. A follow-up could rename it and/or expose the same information in a supported way (e.g. via CMake targets, see #23291), keeping it as the single source of truth for the ACLiC command line.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
skip-ci, posting here just to give the idea.
Builds on top of #23261
It opens up the possibility of not having to depend everything on Core if one just wants RConfig / RConfigure headers.
Follow-up also have Rtypes.h outside of Core. Would disentangle some build dependencies. Maybe it helps for #6432
And to work also on root-config https://its.cern.ch/jira/browse/ROOT-8061