[ntuple] Deprecate some cluster-level descriptor queries - #23339
Merged
Merged
Conversation
silverweed
reviewed
Sep 11, 2026
Test Results 23 files 23 suites 3d 19h 52m 39s ⏱️ Results for commit b1f5803. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
ntuple-huge-file-read
branch
2 times, most recently
from
September 14, 2026 11:36
3b86bfb to
15f14e2
Compare
jblomer
force-pushed
the
ntuple-huge-file-read
branch
from
September 14, 2026 11:47
15f14e2 to
009c525
Compare
jblomer
force-pushed
the
ntuple-huge-file-read
branch
from
September 14, 2026 13:59
009c525 to
b1f5803
Compare
Move the implementation of GetNElements() from RNTupleDescriptor, where it is to be deprecated, to RPageSource. Optimize such that only the last cluster group is needed.
Rename this function to `GetActiveClusterIterable()` making clear that in general not all cluster metadata is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for huge file support. Query methods in the descriptor that iterate clusters are deprecated. The corresponding functionality needs to move in the page source because the descriptor, in general, does not have all cluster meta-data loaded. The page source knows how to load cluster meta-data when needed (to be implemented).
A follow-up PR will deal with the remaining descriptor methods
FindClusterId()andGet[Next|Prev]ClusterId().