Skip to content

[CI] Check installed TMVA headers for syntax errors - #23387

Merged
hageboeck merged 5 commits into
root-project:masterfrom
hageboeck:TMVA_headerCheck
Sep 18, 2026
Merged

hageboeck merged 5 commits into
root-project:masterfrom
hageboeck:TMVA_headerCheck

Conversation

@hageboeck

@hageboeck hageboeck commented Sep 16, 2026

Copy link
Copy Markdown
Member

Now that the header check is merged, start unmasking some of the suppressions.

LLM disclosure: Asked an LLM what the required includes should be. Verified by compiling and testing the classic way.

@hageboeck hageboeck self-assigned this Sep 16, 2026
Comment thread test/PostInstall/check-headers.sh Outdated
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 18h 40m 50s ⏱️
 3 876 tests  3 871 ✅ 0 💤 5 ❌
80 052 runs  80 047 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit 225ee8c.

♻️ This comment has been updated with latest results.

@hageboeck
hageboeck force-pushed the TMVA_headerCheck branch 3 times, most recently from d91ea29 to 47b8229 Compare September 17, 2026 14:34
@hageboeck hageboeck added the clean build Ask CI to do non-incremental build on PR label Sep 17, 2026
The headers could not be included standalone because a few includes were
missing.
Remove the suppressions for TMVA headers.

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hageboeck
hageboeck merged commit 08fde0c into root-project:master Sep 18, 2026
106 of 113 checks passed
@hageboeck
hageboeck deleted the TMVA_headerCheck branch September 18, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants