Skip to content

[tree] deprecate implementation detail header TreeUtils.h - #23393

Merged
pcanal merged 1 commit into
root-project:masterfrom
ferdymercury:btreut
Sep 17, 2026
Merged

pcanal merged 1 commit into
root-project:masterfrom
ferdymercury:btreut

Conversation

@ferdymercury

Copy link
Copy Markdown
Collaborator

it's only used by .cxx files and there is already public interface for it

@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Sep 16, 2026

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ferdymercury ferdymercury added this to the 6.42.00 milestone Sep 16, 2026
@github-actions

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 19h 52m 5s ⏱️
 3 879 tests  3 879 ✅ 0 💤 0 ❌
80 055 runs  80 055 ✅ 0 💤 0 ❌

Results for commit 1f42923.

@pcanal
pcanal merged commit bdd17bb into root-project:master Sep 17, 2026
34 of 35 checks passed
@ferdymercury
ferdymercury deleted the btreut branch September 17, 2026 21:28
@hageboeck

Copy link
Copy Markdown
Member

There is a new warning in ROOT builds now:

[3232/6650] Generating G__Tree.cxx, ../../lib/Tree.pcm
In file included from input_line_10:46:
/root/build/include/TreeUtils.h:26:2: warning: "This header is deprecated and will be removed in ROOT 6.44, use instead TNtuple::ReadStream or TNtupleD::ReadStream" [-W#warnings]
#warning "This header is deprecated and will be removed in ROOT 6.44, use instead TNtuple::ReadStream or TNtupleD::ReadStream"
 ^
In file included from <<< cling interactive line includer >>>:38:
/root/build/include/TreeUtils.h:26:2: warning: "This header is deprecated and will be removed in ROOT 6.44, use instead TNtuple::ReadStream or TNtupleD::ReadStream" [-W#warnings]
#warning "This header is deprecated and will be removed in ROOT 6.44, use instead TNtuple::ReadStream or TNtupleD::ReadStream"
 ^

Could you have a look?

ferdymercury added a commit to ferdymercury/root that referenced this pull request Sep 18, 2026
@guitargeek

guitargeek commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Here is how I typically avoid deprecation warnings when building ROOT itself:

The idea is to define some ROOFIT_BUILDS_ITSELF or similar macro that is only active when ROOT builds itself, and the deprecation warning is conditional on the macro being not defined.

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Could you have a look?

Maybe with #23413 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants