Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pr-review-fixer.sh beginbuilds the enriched queue entry with:jq -n --argjson diff_map "$DIFF_MAP" ...The kernel caps a single argument at 128 KiB (
MAX_ARG_STRLEN), so any PR whose parsed diff map exceeds that crashesbeginwith:line 162: jq: Argument list too longPRs with ~300 KiB diffs (e.g. rossoctl/moca#856, rossoctl/cortex#1934) hit this deterministically, killing the whole fixer run — including the PRs before them in the queue already marked
in_progressin the temp state. The follow-up append (--argjson entry "$enriched") has the same exposure.Fix
Write the diff map and the built entry to temp files and read them with
--slurpfileinstead — the same file-based pattern the state write already uses ("avoids argument-length limits", seepr_review_state_write).Verification
tests/test-vendor-engine.shpasses.beginagainst the live queue now processes all 5 eligible PRs, including a 5802-line / 119-file diff map, where it previously died mid-queue with the error above.🤖 Generated with Claude Code