Repository navigation
Conversation
Rename Rust and npm packages and update platform loaders, examples, and documentation. Publish only the Rspack Rust crate, add release dry runs and installed-package checks, upgrade the WASM optimizer, and pin CI actions to commit SHAs.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
Reset rspack_lightningcss to 0.1.0 and synchronize the N-API dependency, lockfile, and documentation. Remove the npm, CLI, and WASM release workflow while keeping Rust publishing and existing Node/WASM tests.
Restore the release workflow with its existing action pins, dry-run checks, and Rust release workflow call. Document both manual release entry points while keeping the Rust crate version at 0.1.0.
Keep the upstream README body unchanged and put fork purpose, package names, versioning, and manual release instructions in a note at the top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish the Rspack fork as
rspack_lightningcss, starting the Rust crate at0.1.0, with manually triggered Rust and npm/CLI/WASM release workflows.Rename the main Rust crate and update imports, examples, dependency references, the lockfile, and documentation.
Keep the standalone
release-cratesworkflow with publish preflight checks and adry_runoption. Only the main crate is published; helper crates use existing crates.io releases.Keep the manual
releaseworkflow for npm, CLI, and WASM packages, including installed-tarball checks and the Rust release workflow call. Both release entry points supportdry_run; neither runs automatically on pushes or tags.Pin CI actions to commit SHAs and update Binaryen to 133 for WASM test builds.
Preserve the upstream README body unchanged and add the fork's purpose, package names, versioning, and manual release instructions in a note at the top.
Usage example
For example, dispatch
release-crateswithdry_run: trueto package and compilerspack_lightningcss 0.1.0without uploading it. Dispatchreleasewithdry_run: trueto additionally build and validate the npm, CLI, and WASM packages without publishing.Validation
cargo publish -p rspack_lightningcss --dry-run --allow-dirtypassed for version0.1.0.No packages were published.
by OpenAI Codex