Repository navigation
fix: factor shared custom properties in adjacent rules - #3
Merged
Merged
Conversation
Preserve the original commits from parcel-bundler#1333. Integrate the change with rstackjs/lightningcss master (5aec9d4), retaining the fork package configuration and existing regression tests.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Keep the shared custom-property extraction imports alongside the PrinterTrait refactor from PR #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports parcel-bundler/lightningcss#1333. Preserves all 3 original upstream commits with their original SHAs and authors, then adds a merge commit integrating rstackjs
master(5aec9d4).Adjacent theme rules can repeat custom properties even when their other declarations differ. Extract matching custom properties into a shared selector rule only when the serialized CSS becomes smaller; retain selector compatibility, cascade, importance, nesting, and CSS Modules boundaries.
For example, adjacent
.light { --foreground: #000; --background: #fff }and.dark { --foreground: #000; --background: #222 }can share.light, .dark { --foreground: #000 }while retaining their separate background values. This removes the repeated custom property when the selector cost makes extraction worthwhile.Validation on the resulting tree:
cargo test --all-features --locked: passed, including integration tests and doctests.git diff --check: passed.by OpenAI Codex