Repository navigation
fix: deduplicate prefixes for unparsed text properties - #4
Merged
Merged
Conversation
Preserve the original commits from parcel-bundler#1334. Integrate the change with rstackjs/lightningcss master (5aec9d4), retaining the fork package configuration and existing regression tests.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports parcel-bundler/lightningcss#1334. Preserves all 1 original upstream commit with their original SHAs and authors, then adds a merge commit integrating rstackjs
master(5aec9d4).Combine prefix flags on adjacent unparsed text declarations with identical properties and token values, preserving different values, importance, and intervening overrides.
For example, with Safari 14.1 as the target,
-webkit-text-decoration: underline var(--color); text-decoration: underline var(--color)previously gained another identical WebKit declaration on every minification pass. Emit the prefixed declaration once and retain the unprefixed declaration.Validation on the resulting tree:
cargo test --all-features --locked: passed, including integration tests and doctests.git diff --check: passed.The first test run failed in the unchanged
bundler::tests::test_bundlebecause its media query order wasscreen, printinstead ofprint, screen; the complete rerun passed.by OpenAI Codex