Repository navigation
build(deps): upgrade @wordpress/scripts to 36 and keep Jest - #29
Merged
Merged
Conversation
36.0.0 moves test-unit-js to Vitest and drops the bundled Jest preset. Run the suite through test-unit-jest with jest 30.5.0, drop the deprecated @wordpress/jest-preset-default, and remove the get-uri override that no longer matches.
aryanjasala
previously approved these changes
Oct 1, 2026
Without @wordpress/jest-preset-default the config only found tests/js/**/*.test.js in a node environment, so a test next to the code would be skipped silently. Use the preset's testMatch patterns, jest-environment-jsdom and a CSS/SCSS module mock.
scripts 36 ships markdownlint-cli 0.49.1, which needs minimatch 10, so the minimatch 3.1.4 override from #28 broke lint-md-docs. Replace it with js-yaml 5.4.1, which fixes GHSA-r3ph-w7gj-g6xm in the js-yaml 5.2.3 it pulls in.
aryanjasala
approved these changes
Oct 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrades
@wordpress/scriptsfrom 32.3.0 to 36.0.0, which Dependabot proposed in #19, and fixes the JS test setup that 36.0.0 breaks. Stacked on #28; GitHub retargets it tomainonce #28 merges.Why #19 failed
@wordpress/scripts36.0.0 makestest-unit-jsrun Vitest and removes the bundled Jest preset, Babel transform and GitHub Actions reporter thattests/js/jest.config.jsimported. The Jest job failed with "requires Vitest 5".Changes
@wordpress/scripts36.0.0 (the samepackage.jsonand lock result as build(deps): bump basic-ftp and @wordpress/scripts #19).test-unit-jestadapter:test:jsnow callswp-scripts test-unit-jest, andjest30.5.0 is a direct dev dependency.tests/js/jest.config.jsno longer imports the removed@wordpress/scriptsconfig files. The suite is pure Node, so it usestestEnvironment: 'node'and Jest's built-ingithub-actionsreporter.@wordpress/jest-preset-default, which is deprecated and not needed by this suite.get-uri>basic-ftpoverride from fix(deps): patch 69 Dependabot security alerts #28: 36.0.0 no longer depends onget-uri.Vitest is not used yet: the shared
ci-test-jsworkflow passes--ciand--cacheDirectory, which Vitest rejects.Security
With this PR on top of #28, none of the open npm Dependabot alerts remain. It removes the
markdown-it,linkify-it,extract-zipand@opentelemetry/corechains that #28 could not fix.How I verified
Node 22.19:
npm cileaves the lockfile unchanged.lint:js,lint:cssandlint:package-jsonpass.npm run test:jspasses 19 of 19, and so does the CI formnpm run test:js -- --ci --cacheDirectory=<dir>.build:prodpasses. CSS and the*.asset.phpdependency lists matchmain; the block bundles differ only in webpack runtime code, and the asset files are now multi-line.@wordpress/scripts36 declares Node^22.22.2 || ^24.15.0. CI'snode-version: 22resolves to a newer 22.x and satisfies it. Older local Node 22 versions only print an EBADENGINE warning.Once this merges, Dependabot closes #19 as up to date.