Skip to content

Close Logger-owned files when creation fails #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Close Logger-owned files when creation fails #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/logger/log_device.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ def open_logfile(filename)
end

def create_logfile(filename)
logdev = nil
success = false
begin
logdev = File.open(filename, MODE_TO_CREATE)
logdev.flock(File::LOCK_EX)
Expand All @@ -138,10 +140,13 @@ def create_logfile(filename)
logdev.binmode if @binmode
add_log_header(logdev) unless @skip_header
logdev.flock(File::LOCK_UN)
success = true
logdev
rescue Errno::EEXIST
# file is created by another process
open_logfile(filename)
ensure
logdev.close if logdev and !success
end
end

Expand Down