x509store: add X509::Store{,Context}#flags and #clear_flags#1067
Open
rhenium wants to merge 1 commit into
Open
x509store: add X509::Store{,Context}#flags and #clear_flags#1067rhenium wants to merge 1 commit into
rhenium wants to merge 1 commit into
Conversation
OpenSSL::X509::Store{,Context}#flags= does not clear existing flags.
Instead, it ORs new flags to the current set. This is contrary to
normal convention and likely unintentional, but changing the behavior
would not be acceptable for compatibility reasons.
Add #flags to get the current flags to allow users to explicitly express
the intention with "store.flags |= OpenSSL::X509::V_...".
Also, add #clear_flags to remove existing flags. The underlying OpenSSL
C APIs appear to have been added in a patch release of OpenSSL 0.9.8.
Warn in #flags= if the argument is not a superset of the existing flags.
rhenium
force-pushed
the
ky/x509store-flags-warn-add
branch
from
ab87f22 to
a245620
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL::X509::Store{,Context}#flags=does not clear existing flags. Instead, it ORs new flags to the current set. This is contrary to normal convention and likely unintentional, but changing the behavior would not be acceptable for compatibility reasons.Add
#flagsto get the current flags to allow users to explicitly express the intention withstore.flags |= OpenSSL::X509::V_.... Also, add#clear_flagsto remove existing flags. The underlying OpenSSL C APIs appear to have been added in a patch release of OpenSSL 0.9.8.Warn in
#flags=if the argument is not a superset of the existing flags.