Skip to content

Fix race condition in rake parse:topgems #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kddnewton merged 1 commit into from
Sep 15, 2025
Merged

Fix race condition in rake parse:topgems #3648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions rakelib/lex.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,10 @@ module Prism
def parallelize(items, &block)
Thread.abort_on_exception = true

queue = Queue.new
items.each { |item| queue << item }
queue = Queue.new(items).close

workers =
ENV.fetch("WORKERS") { 16 }.to_i.times.map do
ENV.fetch("WORKERS", "16").to_i.times.map do
parallelize_thread(queue, &block)
end

Expand All @@ -77,7 +76,11 @@ module Prism

# Create a new thread with a minimal number of locals that it can access.
def parallelize_thread(queue, &block)
Thread.new { block.call(queue.shift) until queue.empty? }
Thread.new do
while item = queue.pop
block.call(item)
end
end
end
end
end
Expand Down
Loading