Repository navigation
Conversation
This makes it so that you do not have to recurse when serializing and deserializing, making this safe for deep trees.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that you do not have to recurse when serializing and deserializing, making this safe for deep trees. There's a bit of extension to make lazy def bodies work — we put a marker in the says how much of the node to skip (i.e., the header) and then a length for the body. Other than that it should all be the same.
cc @enebo @eregon I'm definitely not super confident on the Java side, but it seems correct-ish. Let me know what you think. I'm hoping to get this out for 2.0 so we're fully safe for deep trees.