JM: Prevent duplicate organizations with the same name

[maebeale]

🤖 suggested review level: 3 Read 📖 unique index + validation, migration aborts on existing dupes

Organizations can no longer be saved twice under the same name, so the deduper stops refilling.

• Index is case-insensitive — utf8mb4_unicode_ci treats Hope House, hope house, and Hope House as the same name. The model validation (case_sensitive: false) matches it.
• Migration aborts if dupes exist — it lists each group with ids; merge them at /organizations/dedupe_index first. Same pattern as Prevent duplicate people with the same name and email #2632.
• Prod has 6 duplicate groups today — one is 26 placeholder rows named "Delete". Clear them before this deploys.
• Removed now-impossible "ambiguous name" branches — form auto-processing (PublicFormSubmission) and the resolve_resource_organizations backfill no longer handle two orgs with one name.
• Factory names get a sequence suffix — avoids random Faker collisions.
• Legitimately distinct same-name orgs need a disambiguator in the name (e.g. city).

🤖 Generated with Claude Code

[jmilljr24]

Whats this for?

[maebeale]

🤖 From Claude: Only the spec used it, so it’s gone now and the spec names the index directly.

The validation handles normal saves; the index is the backstop for two simultaneous saves or writes that skip validation, and that spec checks the backstop.

[maebeale]

@jmilljr24 you ok w my running this in production to dedupe the 31 "DELETE" organizations?

# Merge every organization named "Delete" into the lowest-id one, the same way the
# admin dedupe page does (Dedupable#dedupe_perform + OrganizationsController#dedupe_config).
# Paste into a Rails console. Dry run by default; set DRY_RUN = false to execute.
DRY_RUN = true

orgs = Organization.where(name: "Delete").order(:id).to_a
keep, *dupes = orgs
puts "Keeping ##{keep.id}; merging #{dupes.size}: #{dupes.map(&:id).join(", ")}"

deduper = ModelDeduper.new(model_class: Organization, logger: Logger.new($stdout), dry_run: false)

blocked = dupes.filter_map do |dupe|
  gaps = deduper.unhandled_references(dupe)
  "##{dupe.id}: #{gaps.map { |g| "#{g[:table]}.#{g[:column]}" }.join(", ")}" if gaps.any?
end
abort "Unhandled references, aborting:\n#{blocked.join("\n")}" if blocked.any?

dupes.each do |dupe|
  moved = deduper.reassignment_counts(dupe)
  puts "##{dupe.id} → ##{keep.id} #{moved.presence || "(nothing to move)"}"
end

if DRY_RUN
  puts "DRY RUN — nothing changed."
else
  ActiveRecord::Base.transaction do
    dupes.each do |dupe|
      keep.reload
      keep.filemaker_code = Organization.join_filemaker_codes(keep.filemaker_code, dupe.filemaker_code)
      signature = AddressDeduper.primary_signature(keep, dupe)
      deduper.merge(keep, dupe)
      AddressDeduper.new(keep, primary_signature: signature).call
      keep.save! if keep.changed?
    end
  end
  puts "Done. Remaining \"Delete\" orgs: #{Organization.where(name: "Delete").pluck(:id).inspect}"
end

[jmilljr24]

@jmilljr24 you ok w my running this in production to dedupe the 31 "DELETE" organizations?

# Merge every organization named "Delete" into the lowest-id one, the same way the
# admin dedupe page does (Dedupable#dedupe_perform + OrganizationsController#dedupe_config).
# Paste into a Rails console. Dry run by default; set DRY_RUN = false to execute.
DRY_RUN = true

orgs = Organization.where(name: "Delete").order(:id).to_a
keep, *dupes = orgs
puts "Keeping ##{keep.id}; merging #{dupes.size}: #{dupes.map(&:id).join(", ")}"

deduper = ModelDeduper.new(model_class: Organization, logger: Logger.new($stdout), dry_run: false)

blocked = dupes.filter_map do |dupe|
  gaps = deduper.unhandled_references(dupe)
  "##{dupe.id}: #{gaps.map { |g| "#{g[:table]}.#{g[:column]}" }.join(", ")}" if gaps.any?
end
abort "Unhandled references, aborting:\n#{blocked.join("\n")}" if blocked.any?

dupes.each do |dupe|
  moved = deduper.reassignment_counts(dupe)
  puts "##{dupe.id} → ##{keep.id} #{moved.presence || "(nothing to move)"}"
end

if DRY_RUN
  puts "DRY RUN — nothing changed."
else
  ActiveRecord::Base.transaction do
    dupes.each do |dupe|
      keep.reload
      keep.filemaker_code = Organization.join_filemaker_codes(keep.filemaker_code, dupe.filemaker_code)
      signature = AddressDeduper.primary_signature(keep, dupe)
      deduper.merge(keep, dupe)
      AddressDeduper.new(keep, primary_signature: signature).call
      keep.save! if keep.changed?
    end
  end
  puts "Done. Remaining \"Delete\" orgs: #{Organization.where(name: "Delete").pluck(:id).inspect}"
end

I'm 99% confident it's fine to do but its their data and I think it's worth the quick question to ask them to scan the list first before we do it on their behalf. We don't know why they labeled them "delete" even though we could assume.