Repository navigation
Conversation
Turbo drops the fragment when following a 303 form redirect, leaving admins at the top of the registration editor. Carry the section target in a query parameter and let the existing reveal controller scroll to it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1steve78
force-pushed
the
enable-turbo-on-recipient-shoutout
branch
from
October 12, 2026 17:52
5812a32 to
1053517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable Turbo Drive on recipients shout-out form and ensure 303 redirect
Re-enables Turbo Drive on the recipients page shout-out form and aligns controller guard redirects with HTTP 303 See Other so submissions feel faster and avoid unnecessary full-page reloads.
What is the goal of this PR and why is this important?
app/views/events/recipients.html.erb) as part of the audit of remainingturbo: falseoccurrences following [PR #2619](Re-enable Turbo Drive on admin forms and replace redundant submit-onc… #2619).How did you approach the change?
status: :see_other(303) to the guard redirect inEventsController#feature_recipient_shoutoutwhen the recipient selection is blank or locked.data: { turbo: false }from the shout-outform_withblock.data-turbo-submits-with="Adding…"to the submit button.spec/requests/events_spec.rbto asserthave_http_status(:see_other)across the relevant redirect pathways.spec/system/events_recipient_shoutout_spec.rbto verify Turbo submission, TomSelect selection, alert rendering, and button disabling.UI testing checklist
/events/:id/recipients) as an admin.Anything else to add?
searchable_select_controller.jsalready implements Turbo cache anddisconnect()teardown handlers, so no JavaScript changes were required.