Repository navigation
Flag people with multiple user accounts and link to merging them - #2661
Merged
Merged
Conversation
maebeale
force-pushed
the
maebeale/multiple-accounts-flag
branch
3 times, most recently
from
October 14, 2026 13:09
79738be to
0de8ef9
Compare
maebeale
changed the title
maebeale
commented
Oct 14, 2026
|
|
||
| label = mc.model_name.human.pluralize | ||
| redirect_to url_for(action: :index), | ||
| redirect_to dedupe_return&.dig(:path) || url_for(action: :index), |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: This is in the shared Dedupable concern, so every deduper honors return_to. Only the person warning sends it, though, and it only targets the logins merge, where the person survives. A people merge with return_to would land on the deleted person.
maebeale
marked this pull request as ready for review
October 14, 2026 13:20
maebeale
force-pushed
the
maebeale/multiple-accounts-flag
branch
from
October 14, 2026 13:24
0de8ef9 to
cdc8169
Compare
maebeale
changed the title
maebeale
force-pushed
the
maebeale/multiple-accounts-flag
branch
2 times, most recently
from
October 14, 2026 16:07
6f04a2e to
ad1393c
Compare
jmilljr24
approved these changes
Oct 14, 2026
maebeale
force-pushed
the
maebeale/multiple-accounts-flag
branch
from
October 15, 2026 00:03
ad1393c to
71d3815
Compare
maebeale
changed the title
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A merge can leave a person with two logins. The profile shows only the most recently used one, so admins had no way to see or reach the others. The new warning mirrors the multiple-memberships flag and links to every account. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Main now has a logins deduper. Linking each extra account to its merge preview, with the deduper's suggested keeper picked, turns the warning into a fix. The preview and the finished merge return to the person page the admin started on. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/multiple-accounts-flag
branch
from
October 15, 2026 00:21
71d3815 to
a484cdd
Compare
Internal notes sit behind an unlisted ?admin switch, so the features page shouldn't advertise them. Also drops two stale pro-tip lines an earlier rebase left in the seed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/multiple-accounts-flag
branch
from
October 15, 2026 00:27
a484cdd to
7b6a215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 admin-only warning + small return_to hook in the shared dedupe preview
Admins can now see when a person has more than one user account, open each one, and merge the extras from the person's page. A merge can leave a person with two logins, and until now the profile only showed one.
UserPolicy#index?).Person#user's ordering.Dedupablegainsreturn_to=person_show|person_edit+person_id. With those params, the preview's back link, Cancel, Swap, and the post-merge redirect all return to the person. Other dedupers are unchanged.User.where(person_id:)in the decorator. It doesn't add ahas_many :usersassociation, becauseAhoyTrackablereflects on every association.?adminswitch.🤖 Generated with Claude Code