Skip to content

Email registrant and admins a DUPLICATE notice (with what changed) when someone resubmits a registration - #2684

Merged
maebeale merged 4 commits into
mainfrom
maebeale/scholarship-email-confirmation-missing
Oct 14, 2026
Merged

maebeale merged 4 commits into
mainfrom
maebeale/scholarship-email-confirmation-missing

Conversation

@maebeale

@maebeale maebeale commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 3 Read 📖 new registrant + admin emails on the resubmission path, plus a change-diff PORO

When someone who's already registered submits the registration form again, they get a "DUPLICATE" confirmation email and programs gets a "[FYI] DUPLICATE" email. Before this, nobody was emailed, so a scholarship request that came in on a second submission went unnoticed.

  • Two new notification kinds:
    • event_registration_duplicate (registrant): the normal confirmation email with DUPLICATE in the subject and heading.
    • event_registration_duplicate_fyi (admin).
  • Both emails list what the resubmission changed:
    • registration settings: scholarship, CE, W-9, invoice, payment method, who's paying
    • newly linked organizations
    • every registration-form answer that differs from the person's previous submission (name, address, sectors, …)
  • ResubmissionChanges compares the registration before and after, and diffs answers against the prior submission.
    • It diffs answers rather than reading the Ahoy write log because identity fields aren't overwritten for existing people. A name change would never show up in that log.
    • An answer left out of the resubmission is skipped, since hidden "answers on file" fields aren't posted.
    • The change notes travel in custom_message, so a resend from Communications reproduces the same email.
  • Subject suffix: (scholarship now requested) when a scholarship was added, (registration changed) for any other change.
  • Re-registering after a cancellation still sends the normal confirmation + FYI, as before.
  • Two Communications topic filters added.
  • The admin FYI event card is shared via _event_registration_fyi_details partials.

🤖 Generated with Claude Code

@maebeale
maebeale marked this pull request as ready for review October 14, 2026 14:47
@maebeale maebeale changed the title Email admins a DUPLICATE FYI when someone resubmits a registration Email registrant and admins a DUPLICATE notice (with what changed) when someone resubmits a registration Oct 14, 2026
@maebeale
maebeale requested a review from jmilljr24 October 14, 2026 15:09
@maebeale maebeale changed the title Email registrant and admins a DUPLICATE notice (with what changed) when someone resubmits a registration JM: Email registrant and admins a DUPLICATE notice (with what changed) when someone resubmits a registration Oct 14, 2026
maebeale and others added 4 commits October 14, 2026 12:06
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Resubmitting against an active registration silently merged the answers
(including a new scholarship request) with no email to anyone, so staff
missed scholarship applications that arrived as second submissions.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ion change

Registrants who resubmitted heard nothing back either, and admins only saw a
scholarship change — CE, W-9, invoice, payment method, and who's paying changes
were merged silently.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…emails

Staff need to see everything a resubmission changed, not just the registration
flags: a new name, address, sectors, or organization otherwise goes unnoticed.
Answers are diffed against the previous submission rather than read from the
record-write log, since identity fields aren't overwritten for existing people.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@maebeale
maebeale force-pushed the maebeale/scholarship-email-confirmation-missing branch from 9141e17 to e59fa70 Compare October 14, 2026 16:12
@maebeale maebeale changed the title JM: Email registrant and admins a DUPLICATE notice (with what changed) when someone resubmits a registration Email registrant and admins a DUPLICATE notice (with what changed) when someone resubmits a registration Oct 14, 2026
@maebeale
maebeale merged commit ef18653 into main Oct 14, 2026
3 checks passed
@maebeale
maebeale deleted the maebeale/scholarship-email-confirmation-missing branch October 14, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants