Repository navigation
Stop requiring a status on organizations - #2685
Merged
Merged
Conversation
The stored organization_status is derived from affiliations and many legacy orgs have none, so requiring it blocked admins from merging duplicates. The preview also silently stamped the first status onto a blank keeper. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The stored status is derived from affiliations and nothing reads it as an input anymore (ADR-0003 D4), so requiring it only blocked saves — dedupe merges included — on legacy orgs that never had one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
changed the title
A bare blank option reads like a missing render, so an org without a status looked like it had one or like the select was broken. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 drops a model validation; small diff but every org save path is affected
Organizations no longer need a status to be saved, which unblocks merging duplicate orgs that never had one.
What is the goal of this PR and why is this important?
organization_statusis derived from affiliations and isn't consulted as an input (ADR-0003 D4).How did you approach the change?
belongs_to :organization_statusis now optional and the presence validation is gone.Anything else to add?
🤖 Generated with Claude Code